From c58b073a7373a0c349ae6947b5b0228e62649ca7 Mon Sep 17 00:00:00 2001
From: Sarjuuk <junkdump@gmx.net>
Date: Wed, 28 Jan 2026 19:50:55 +0100
Subject: [PATCH] Quests/Fixup  * fix inconsistency in linking to categoy:
 uncategorized (-2)  * fixes #485

---
 endpoints/quests/quests.php | 7 +++++++
 static/js/locale_dede.js    | 1 +
 static/js/locale_enus.js    | 1 +
 static/js/locale_eses.js    | 1 +
 static/js/locale_frfr.js    | 1 +
 static/js/locale_ruru.js    | 1 +
 static/js/locale_zhcn.js    | 1 +
 7 files changed, 13 insertions(+)

diff --git a/endpoints/quests/quests.php b/endpoints/quests/quests.php
index 7473577d..86dc7e9b 100644
--- a/endpoints/quests/quests.php
+++ b/endpoints/quests/quests.php
@@ -52,7 +52,14 @@ class QuestsBaseResponse extends TemplateResponse implements ICache
         parent::__construct($rawParam);
 
         if ($this->category)
+        {
+            // basically: everywhere except for page structure quests require cat AND cat2 to be set
+            // causing links to be generated for /?quests=-2.0, which only exist as /?quests=-2
+            if ($this->category[0] == -2 && isset($this->category[1]))
+                $this->forward('?' . $this->pageName . '=-2');
+
             $this->subCat = '='.implode('.', $this->category);
+        }
 
         $this->filter = new QuestListFilter($this->_get['filter'] ?? '', ['parentCats' => $this->category]);
         if ($this->filter->shouldReload)
diff --git a/static/js/locale_dede.js b/static/js/locale_dede.js
index d4bea2c6..13149b44 100644
--- a/static/js/locale_dede.js
+++ b/static/js/locale_dede.js
@@ -1531,6 +1531,7 @@ var g_quest_sorts = {
      "-374": 'Nobelgarten',
      "-375": 'Pilgerfreuden',
      "-376": 'Liebe liegt in der Luft',
+          0: 'Nicht kategorisiert',
           1: 'Dun Morogh',
           3: 'Ödland',
           4: 'Verwüstete Lande',
diff --git a/static/js/locale_enus.js b/static/js/locale_enus.js
index e63774ec..2886bafa 100644
--- a/static/js/locale_enus.js
+++ b/static/js/locale_enus.js
@@ -1578,6 +1578,7 @@ var g_quest_sorts = {
      "-374": 'Noblegarden',
      "-375": 'Pilgrim\'s Bounty',
      "-376": 'Love is in the Air',
+          0: 'Uncategorized',
           1: 'Dun Morogh',
           3: 'Badlands',
           4: 'Blasted Lands',
diff --git a/static/js/locale_eses.js b/static/js/locale_eses.js
index 2bcea8a7..7434c43f 100644
--- a/static/js/locale_eses.js
+++ b/static/js/locale_eses.js
@@ -1531,6 +1531,7 @@ var g_quest_sorts = {
      "-374": 'Jardín Noble',
      "-375": 'Generosidad del Peregrino',
      "-376": 'Amor en el aire',
+          0: 'Sin categoría',
           1: 'Dun Morogh',
           3: 'Tierras Inhóspitas',
           4: 'Las Tierras Devastadas',
diff --git a/static/js/locale_frfr.js b/static/js/locale_frfr.js
index 0dd922c2..205e8371 100644
--- a/static/js/locale_frfr.js
+++ b/static/js/locale_frfr.js
@@ -1531,6 +1531,7 @@ var g_quest_sorts = {
      "-374": 'Jardin des nobles',
      "-375": 'Bienfaits du pèlerin',
      "-376": 'De l\'amour dans l\'air',
+          0: 'Non classés',
           1: 'Dun Morogh',
           3: 'Terres ingrates',
           4: 'Terres foudroyées',
diff --git a/static/js/locale_ruru.js b/static/js/locale_ruru.js
index e3cb937c..b63439fb 100644
--- a/static/js/locale_ruru.js
+++ b/static/js/locale_ruru.js
@@ -1531,6 +1531,7 @@ var g_quest_sorts = {
      "-374": 'Сад чудес',
      "-375": 'Пиршество странников',
      "-376": 'Любовная лихорадка',
+          0: 'Разное',
           1: 'Дун Морог',
           3: 'Бесплодные земли',
           4: 'Выжженные земли',
diff --git a/static/js/locale_zhcn.js b/static/js/locale_zhcn.js
index 08ff9df4..7447f0a4 100644
--- a/static/js/locale_zhcn.js
+++ b/static/js/locale_zhcn.js
@@ -1577,6 +1577,7 @@ var g_quest_sorts = {
      "-374": '复活节',
      "-375": '感恩节',
      "-376": '情人节',
+          0: '未分类',
           1: '丹莫罗',
           3: '荒芜之地',
           4: '诅咒之地',