From 15f20a63f7ddfe5018892f6f3062fe4ed3aacafd Mon Sep 17 00:00:00 2001 From: Sarjuuk Date: Tue, 24 Feb 2026 17:53:56 +0100 Subject: [PATCH] Quests/Fixup * fix 'Side' displayed in infobox on detail page * don't display 'Races' in infobox if they encompass an entire faction --- endpoints/quest/quest.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/endpoints/quest/quest.php b/endpoints/quest/quest.php index 36f70470..38fad38b 100644 --- a/endpoints/quest/quest.php +++ b/endpoints/quest/quest.php @@ -160,7 +160,7 @@ class QuestBaseResponse extends TemplateResponse implements ICache $infobox[] = Lang::game('type').implode(' ', $_); // side - $infobox[] = Lang::main('side') . match ($this->subject->getField('faction')) + $infobox[] = Lang::main('side') . match ($_side) { SIDE_ALLIANCE => '[span class=icon-alliance]'.Lang::game('si', SIDE_ALLIANCE).'[/span]', SIDE_HORDE => '[span class=icon-horde]'.Lang::game('si', SIDE_HORDE).'[/span]', @@ -169,7 +169,7 @@ class QuestBaseResponse extends TemplateResponse implements ICache // races $jsg = []; - if ($_ = Lang::getRaceString($this->subject->getField('reqRaceMask'), $jsg, Lang::FMT_MARKUP)) + if (($_ = Lang::getRaceString($this->subject->getField('reqRaceMask'), $jsg, Lang::FMT_MARKUP)) && $jsg) { $this->extendGlobalIds(Type::CHR_RACE, ...$jsg); $t = count($jsg) == 1 ? Lang::game('race') : Lang::game('races');