From 319bd0593099ac41dd2f9e840e7f9cbf61b9e464 Mon Sep 17 00:00:00 2001 From: Florian Berthold Date: Mon, 8 Jun 2026 20:42:10 +0200 Subject: [PATCH 1/3] fix(necromancer): ship bar layout in defaults so existing profiles don't crash The necromancerBar height/order/background only reached a profile via the defaultlayout merge, which runs on profile reset. Enabling the bar on a pre-existing profile left height nil, crashing Layout:PositionWidgets ("attempt to compare number with nil" at layout.lua:441). Carry the layout in the AceDB defaults so it resolves via the defaults metatable for old and new profiles alike. --- ShadowedUnitFrames/ShadowedUnitFrames.lua | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ShadowedUnitFrames/ShadowedUnitFrames.lua b/ShadowedUnitFrames/ShadowedUnitFrames.lua index c7878a0..7fb1109 100644 --- a/ShadowedUnitFrames/ShadowedUnitFrames.lua +++ b/ShadowedUnitFrames/ShadowedUnitFrames.lua @@ -243,7 +243,11 @@ function ShadowUF:LoadUnitDefaults() self.defaults.profile.units.player.runeBar = {enabled = false} self.defaults.profile.units.player.totemBar = {enabled = false} self.defaults.profile.units.player.druidBar = {enabled = false} - self.defaults.profile.units.player.necromancerBar = {enabled = false} + -- Carry the layout (height/order/background) in the defaults, not only in the + -- defaultlayout merge: that merge only runs on profile reset, so a bar added to + -- an existing profile would otherwise have a nil height and crash + -- Layout:PositionWidgets ("attempt to compare number with nil" in layout.lua). + self.defaults.profile.units.player.necromancerBar = {enabled = false, height = 0.40, order = 26, background = true} self.defaults.profile.units.player.xpBar = {enabled = false} self.defaults.profile.units.player.fader = {enabled = false, combatAlpha = 1.0, inactiveAlpha = 0.60} self.defaults.profile.units.player.indicators.lfdRole = {enabled = true, size = 0, x = 0, y = 0} From 4d2ef28ad05d60f6a6747c01ff3d355851b3ba2d Mon Sep 17 00:00:00 2001 From: Florian Berthold Date: Wed, 10 Jun 2026 02:11:47 +0200 Subject: [PATCH 2/3] ci(release): sync release.yml from coa-template MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit hide_archive_links is only honored by Gitea on release edit, not create — add the PATCH step after create/lookup so auto-generated source archive links actually stay hidden (coa-template 90874c5). --- .gitea/workflows/release.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.gitea/workflows/release.yml b/.gitea/workflows/release.yml index 709a7cd..2f93975 100644 --- a/.gitea/workflows/release.yml +++ b/.gitea/workflows/release.yml @@ -37,10 +37,14 @@ jobs: RID=$(curl -sf -X POST -H "Authorization: token $GITEA_TOKEN" \ -H "Content-Type: application/json" \ "$API/repos/$REPO/releases" \ - -d "$(jq -nc --arg t "$TAG" '{tag_name:$t,name:$t,draft:false,prerelease:false}')" \ + -d "$(jq -nc --arg t "$TAG" '{tag_name:$t,name:$t,draft:false,prerelease:false,hide_archive_links:true}')" \ | jq -r '.id') fi echo "release id: $RID" + # Gitea honors hide_archive_links only on edit, not create — PATCH it + # so the auto-generated Source Code (zip/tar.gz) links stay hidden. + curl -sf -X PATCH -H "Authorization: token $GITEA_TOKEN" -H "Content-Type: application/json" \ + "$API/repos/$REPO/releases/$RID" -d '{"hide_archive_links":true}' >/dev/null || true # Upload every dist/*.zip. Per-asset failures don't fail the job — # we want partial releases to still publish rather than block the # whole pipeline on one big file. From 2aad7af12d302a6fb483261cfc2cbcb070849da2 Mon Sep 17 00:00:00 2001 From: Florian Berthold Date: Wed, 10 Jun 2026 02:16:14 +0200 Subject: [PATCH 3/3] chore: bump toc Version to v3.3.0-coa.7 to match latest release tag --- ShadowedUnitFrames/ShadowedUnitFrames.toc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShadowedUnitFrames/ShadowedUnitFrames.toc b/ShadowedUnitFrames/ShadowedUnitFrames.toc index f7ccf8c..7d3a63a 100644 --- a/ShadowedUnitFrames/ShadowedUnitFrames.toc +++ b/ShadowedUnitFrames/ShadowedUnitFrames.toc @@ -2,7 +2,7 @@ ## Title: Shadowed Unit Frames ## Notes: An apple a day keeps the raptor away, or so they say ## Author: Shadowed -## Version: v3.3.0-coa.2 +## Version: v3.3.0-coa.7 ## SavedVariables: ShadowedUFDB ## OptionalDeps: Ace3, LibSharedMedia-3.0, LibHealComm-4.0, AceGUI-3.0-SharedMediaWidgets ## X-Curse-Packaged-Version: v3.2.12