From 78e50e9f5cb356067455659d9721fd9f534342ca Mon Sep 17 00:00:00 2001 From: Florian Berthold Date: Fri, 29 May 2026 22:58:45 +0200 Subject: [PATCH 1/6] coa.25: clean two-column Skills layout Skills vertical list now uses a proper two-column row: indented [icon] profession name in the Name cell, rank/max color-coded in its own Level column to the right (was all crammed into one text cell). Character headers span the row with name + (class). --- Altoholic/Altoholic.lua | 2 +- Altoholic/Altoholic.toc | 2 +- Altoholic/Frames/Skills.lua | 22 ++++++++++++++++------ 3 files changed, 18 insertions(+), 8 deletions(-) diff --git a/Altoholic/Altoholic.lua b/Altoholic/Altoholic.lua index 012f338..334d134 100644 --- a/Altoholic/Altoholic.lua +++ b/Altoholic/Altoholic.lua @@ -338,7 +338,7 @@ function addon:OnEnable() -- CoA: use a Lua constant, not GetAddOnMetadata — TOC metadata is cached at game launch -- and does NOT refresh on /reload, so the .toc version looked stale ("still .18"). A Lua -- constant re-evaluates on every /reload, giving a truthful loaded-code version. Bump with the .toc. - AltoholicFrameName:SetText("Altoholic |cFFFFFFFF3.3.002b-coa.24|r") + AltoholicFrameName:SetText("Altoholic |cFFFFFFFF3.3.002b-coa.25|r") local realm = GetRealmName() local player = UnitName("player") diff --git a/Altoholic/Altoholic.toc b/Altoholic/Altoholic.toc index ce64f22..ca0944f 100644 --- a/Altoholic/Altoholic.toc +++ b/Altoholic/Altoholic.toc @@ -13,7 +13,7 @@ ## Author: Thaoky, Telkar-RG ## X-Edited-By: Exiles (Sub-Net) — florian.berthold@sub-net.at -## Version: 3.3.002b-coa.24 +## Version: 3.3.002b-coa.25 ## X-Category: Inventory, Tradeskill, Mail ## X-Localizations: enUS, frFR, zhCN, zhTW, deDE, koKR, esES, esMX, ruRU ## X-Website: http://wow.curse.com/downloads/wow-addons/details/altoholic.aspx diff --git a/Altoholic/Frames/Skills.lua b/Altoholic/Frames/Skills.lua index 413a2d3..d1c74f5 100644 --- a/Altoholic/Frames/Skills.lua +++ b/Altoholic/Frames/Skills.lua @@ -76,27 +76,37 @@ function ns:Update() local item = items[i + offset] if item then _G[e.."Collapse"]:Hide() - _G[e.."Level"]:SetText("") _G[e.."Skill1NormalText"]:SetText("") _G[e.."CookingNormalText"]:SetText("") _G[e.."FirstAidNormalText"]:SetText("") _G[e.."FishingNormalText"]:SetText("") _G[e.."RidingNormalText"]:SetText("") - _G[e.."Name"]:SetWidth(680) - _G[e.."Name"]:SetPoint("TOPLEFT", 15, 0) - _G[e.."NameNormalText"]:SetWidth(680) if item.kind == "header" then + -- character header: colored name + (class) across the row, no rank column + _G[e.."Name"]:SetPoint("TOPLEFT", 15, 0) + _G[e.."Name"]:SetWidth(420) + _G[e.."NameNormalText"]:SetWidth(420) local locClass, engClass = DS:GetCharacterClass(item.character) local className = Altoholic:GetCoAClassName(engClass) or locClass or "" -- CoA: PROPHET->Venomancer, MONK->Templar, … - _G[e.."NameNormalText"]:SetText( (DS:GetColoredCharacterName(item.character) or "?") .. " " .. WHITE .. "(" .. className .. ")" ) + _G[e.."NameNormalText"]:SetText( (DS:GetColoredCharacterName(item.character) or "?") .. " " .. WHITE .. "(" .. className .. ")" ) + _G[e.."Level"]:SetText("") else + -- profession row: [icon] name in the Name cell (indented), rank/max in its own column local iconEsc = "" if item.spellID then iconEsc = addon:TextureToFontstring2(addon:GetSpellIcon(item.spellID), size, size, inset, inset, inset, inset) .. " " end + _G[e.."Name"]:SetPoint("TOPLEFT", 38, 0) + _G[e.."Name"]:SetWidth(200) + _G[e.."NameNormalText"]:SetWidth(200) + _G[e.."NameNormalText"]:SetText( iconEsc .. WHITE .. item.name ) + local cap = (item.maxRank > 0) and item.maxRank or 450 - _G[e.."NameNormalText"]:SetText( " " .. iconEsc .. WHITE .. item.name .. " " .. ns:GetColor(item.rank, cap) .. item.rank .. "/" .. item.maxRank .. "|r" ) + _G[e.."Level"]:SetPoint("TOPLEFT", 250, 0) + _G[e.."Level"]:SetWidth(120) + _G[e.."Level"]:SetJustifyH("LEFT") + _G[e.."Level"]:SetText( ns:GetColor(item.rank, cap) .. item.rank .. " / " .. item.maxRank ) end btn.coaItem = item btn:SetID(item.viewLine or 0) From 863709e45038aac9d4465edfa817ef0ac17ecf55 Mon Sep 17 00:00:00 2001 From: Florian Berthold Date: Fri, 29 May 2026 23:37:56 +0200 Subject: [PATCH 2/6] coa.26: fix Skills frame overlapping the menu (745->615 width) Root cause of the 'all over the place' Skills layout: the Skills content frame was 745 wide (widened at coa.9 for extra columns) vs 615 for every other Summary view. Both anchor TOPRIGHT, so the extra 130px pushed the Skills frame's LEFT edge over the nav menu -> profession names rendered on top of the menu. Restored to 615 so the left edge clears the menu like AccountSummary; the two-column name/rank list now sits in the content area. --- Altoholic/Altoholic.lua | 2 +- Altoholic/Altoholic.toc | 2 +- Altoholic/Frames/Skills.xml | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Altoholic/Altoholic.lua b/Altoholic/Altoholic.lua index 334d134..4fa41e2 100644 --- a/Altoholic/Altoholic.lua +++ b/Altoholic/Altoholic.lua @@ -338,7 +338,7 @@ function addon:OnEnable() -- CoA: use a Lua constant, not GetAddOnMetadata — TOC metadata is cached at game launch -- and does NOT refresh on /reload, so the .toc version looked stale ("still .18"). A Lua -- constant re-evaluates on every /reload, giving a truthful loaded-code version. Bump with the .toc. - AltoholicFrameName:SetText("Altoholic |cFFFFFFFF3.3.002b-coa.25|r") + AltoholicFrameName:SetText("Altoholic |cFFFFFFFF3.3.002b-coa.26|r") local realm = GetRealmName() local player = UnitName("player") diff --git a/Altoholic/Altoholic.toc b/Altoholic/Altoholic.toc index ca0944f..93726ec 100644 --- a/Altoholic/Altoholic.toc +++ b/Altoholic/Altoholic.toc @@ -13,7 +13,7 @@ ## Author: Thaoky, Telkar-RG ## X-Edited-By: Exiles (Sub-Net) — florian.berthold@sub-net.at -## Version: 3.3.002b-coa.25 +## Version: 3.3.002b-coa.26 ## X-Category: Inventory, Tradeskill, Mail ## X-Localizations: enUS, frFR, zhCN, zhTW, deDE, koKR, esES, esMX, ruRU ## X-Website: http://wow.curse.com/downloads/wow-addons/details/altoholic.aspx diff --git a/Altoholic/Frames/Skills.xml b/Altoholic/Frames/Skills.xml index c669b2b..d275ec0 100644 --- a/Altoholic/Frames/Skills.xml +++ b/Altoholic/Frames/Skills.xml @@ -34,7 +34,7 @@ + + + + + + + + + + +